rustyrazorblade commented on code in PR #3606:
URL: https://github.com/apache/cassandra/pull/3606#discussion_r1850394613
##########
src/java/org/apache/cassandra/io/util/CompressedChunkReader.java:
##########
@@ -117,8 +141,23 @@ public void readChunk(long position, ByteBuffer
uncompressed)
{
ByteBuffer compressed = bufferHolder.getBuffer(length);
- if (channel.read(compressed, chunk.offset) != length)
- throw new CorruptBlockException(channel.filePath(),
chunk);
+ if (readAheadBuffer != null && readAheadBuffer.hasBuffer())
+ {
+ int copied = 0;
+ while (copied < length) {
Review Comment:
If someone is using a massive chunk length (I've never seen this in 12
years) then it doesn't really matter if we have the buffer in place because the
reads will be fairly large anyways. So I think whatever is easiest for you to
add is fine. Can you just bypass it in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
