dcapwell commented on code in PR #141:
URL: https://github.com/apache/cassandra-accord/pull/141#discussion_r1851068651
##########
accord-core/src/main/java/accord/coordinate/ExecuteSyncPoint.java:
##########
@@ -195,6 +257,11 @@ protected void onSuccess()
trySuccess(syncPoint);
}
+ protected void sendApply(Node.Id to)
Review Comment:
I don't see it used in https://github.com/apache/cassandra/pull/3698
##########
accord-core/src/main/java/accord/messages/ReadData.java:
##########
@@ -513,10 +513,17 @@ public enum CommitOrReadNack implements ReadData.ReadReply
* The commit has been rejected due to stale ballot.
*/
Rejected("CommitRejected"),
+
/**
* Either not committed, or not stable
*/
Insufficient("CommitInsufficient"),
+
+ /**
+ * PreApplied successfully, but the request is blocking so waiting to
reply
+ */
+ Waiting("ApplyWaiting"),
Review Comment:
I don't see it used in https://github.com/apache/cassandra/pull/3698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
