ifesdjeen commented on code in PR #140:
URL: https://github.com/apache/cassandra-accord/pull/140#discussion_r1850771440
##########
accord-core/src/main/java/accord/coordinate/CoordinateEphemeralRead.java:
##########
@@ -136,6 +136,6 @@ void onPreAccepted(Topologies topologies)
{
Deps deps = Deps.merge(oks, oks.domainSize(), SortedListMap::getValue,
ok -> ok.deps);
topologies = node.topology().reselect(topologies,
QuorumEpochIntersections.preaccept.include, route, executeAtEpoch,
executeAtEpoch, Owned);
- new ExecuteEphemeralRead(node, topologies, route, txnId, txn,
executeAtEpoch, deps, this).start();
+ new ExecuteEphemeralRead(node, topologies, route,
txnId.withEpoch(executeAtEpoch), txn, executeAtEpoch, deps, this).start();
Review Comment:
nit: do we still need to pass an explicit epoch here?
##########
accord-core/src/main/java/accord/coordinate/CoordinateSyncPoint.java:
##########
@@ -172,11 +173,18 @@ void onPreAccepted(Topologies topologies, Timestamp
executeAt, List<PreAcceptOk>
}
public static void sendApply(Node node, Node.Id to, SyncPoint<?> syncPoint)
+ {
+ // TODO (required): consider, document and add invariants checking if
this topologies is correct in all cases
+ // (notably ExclusiveSyncPoints should execute in earlier epochs for
durability, but not for fetching )
+ Topologies executes = executes(node, syncPoint.route,
syncPoint.syncId);
+ sendApply(node, to, syncPoint, executes);
+ }
+ public static void sendApply(Node node, Node.Id to, SyncPoint<?>
syncPoint, Topologies executes)
{
TxnId txnId = syncPoint.syncId;
Timestamp executeAt = txnId;
Review Comment:
nit: do we want this assignment or is this historic?
##########
accord-core/src/main/java/accord/utils/Base62.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package accord.utils;
+
+public class Base62
+{
+ private static final long OVERFLOWL = Long.MAX_VALUE / 62;
Review Comment:
nit: is `L` in the end of the word intended?
##########
accord-core/src/test/java/accord/impl/basic/Journal.java:
##########
@@ -100,9 +101,12 @@ public void purge(IntFunction<CommandStore> storeSupplier)
case TRUNCATE_WITH_OUTCOME:
case TRUNCATE:
case ERASE:
+ if (commandStoreId == 0 && id.id == 1 &&
txnId.toString().equals("[7,12610,9(RX),2]"))
Review Comment:
nit: just in case this is not handled in a follow-up, marking it here
##########
accord-core/src/main/java/accord/utils/Base62.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package accord.utils;
+
+public class Base62
Review Comment:
Have we found an agreement on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
