maulin-vasavada commented on code in PR #3708:
URL: https://github.com/apache/cassandra/pull/3708#discussion_r1857502329
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -1321,7 +1322,8 @@ public enum BatchlogEndpointStrategy
private static final Set<String> SENSITIVE_KEYS = new HashSet<String>() {{
add("client_encryption_options");
add("server_encryption_options");
- add("jmx_encryption_options");
+ // jmx_server_options output (JMXServerOptions.toString()) doesn't
+ // include sensitive encryption config so no need to blacklist here
Review Comment:
@smiklosovic you meant `blocklist` here right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
