Maxwell-Guo commented on code in PR #3718:
URL: https://github.com/apache/cassandra/pull/3718#discussion_r1865836851
##########
src/antlr/Parser.g:
##########
@@ -236,6 +236,7 @@ cqlStatement returns [CQLStatement.Raw stmt]
| st42=addIdentityStatement { $stmt = st42; }
| st43=dropIdentityStatement { $stmt = st43; }
| st44=listSuperUsersStatement { $stmt = st44; }
+ | st45=copyTableStatement { $stmt = st45; }
Review Comment:
The reason i used a new statement here is that :
1、The original createtablestatment code is too bloated. If the semantics of
like are added, the code needs to be changed a lot.
2、In addition, I think this new copystatement can do things other than table
cloning, and can also support semantic capabilities such as “CREATE TABLE AS”.
Because they are similar to table copying functions, they are called
copystatement here.
Besides, I have also prepared a patch, which is mainly to modify the pares
of create table, that is, to implement the function of create table like in
create table statement. If you think it is necessary, I can create a new PR to
replace the current one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
