smiklosovic commented on code in PR #3721:
URL: https://github.com/apache/cassandra/pull/3721#discussion_r1868306506
##########
src/java/org/apache/cassandra/schema/ColumnMetadata.java:
##########
@@ -208,6 +208,11 @@ public ColumnMetadata(String ksName,
this.mask = mask;
}
+ protected ColumnMetadata cloneWithoutTableName(String keyspace, String
table)
+ {
+ return new ColumnMetadata(keyspace, table, name, type, position, kind,
mask);
Review Comment:
this is not a good idea, we are not copying it "deep enough".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
