skoppu22 commented on code in PR #152:
URL: https://github.com/apache/cassandra-sidecar/pull/152#discussion_r1869948751
##########
server/src/main/java/org/apache/cassandra/sidecar/metrics/ServerMetrics.java:
##########
@@ -53,4 +53,9 @@ public interface ServerMetrics
* @return metrics related to internal caches that are tracked.
*/
CacheMetrics cacheMetrics();
+
+ /**
+ * @return metrics related to invocation of C* JMX operations
+ */
+ JmxOperationsMetrics jmxOperationsMetrics();
Review Comment:
This is the first Sidecar endpoint for a jmx operation, we need this, we
will use the same for upcoming endpoints as well which invoke C* JMX
operations. I understand there are existing calls as well in Sidecar invoking
C* JMX, we will need to modify them to publish metrics. I prefer to have
JmxOperationsMetrics accessible in JmxClient.java and record metrics there,
that way each endpoint doesn't have to worry about publishing JMX calls
metrics, instead JmxClient will take care of this for every JMX call being
made, but I need to see the possibility of this.
On another thought, do we really need to track metrics of JMX calls? Does
JVM (or something in Java world) provide this already? If so, we don't need
this.
Note: this is different from Sidecar endpoints invocation metrics, which are
already provided by vertx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
