Maxwell-Guo commented on code in PR #3718: URL: https://github.com/apache/cassandra/pull/3718#discussion_r1871544966
########## src/java/org/apache/cassandra/cql3/statements/schema/CopyTableStatement.java: ########## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3.statements.schema; + +import org.apache.cassandra.audit.AuditLogContext; +import org.apache.cassandra.audit.AuditLogEntryType; +import org.apache.cassandra.auth.Permission; +import org.apache.cassandra.cql3.CQLStatement; +import org.apache.cassandra.cql3.QualifiedName; +import org.apache.cassandra.db.guardrails.Guardrails; +import org.apache.cassandra.exceptions.AlreadyExistsException; +import org.apache.cassandra.schema.Indexes; +import org.apache.cassandra.schema.KeyspaceMetadata; +import org.apache.cassandra.schema.Keyspaces; +import org.apache.cassandra.schema.TableId; +import org.apache.cassandra.schema.TableMetadata; +import org.apache.cassandra.schema.Triggers; +import org.apache.cassandra.schema.UserFunctions; +import org.apache.cassandra.service.ClientState; +import org.apache.cassandra.service.reads.repair.ReadRepairStrategy; +import org.apache.cassandra.tcm.ClusterMetadata; +import org.apache.cassandra.transport.Event.SchemaChange; + +public final class CopyTableStatement extends AlterSchemaStatement +{ + private final String sourceKeyspace; + private final String sourceTableName; + private final String targetKeyspace; + private final String targetTableName; + + public CopyTableStatement(String sourceKeyspace, + String targetKeyspace, + String sourceTableName, + String targetTableName) + { + super(targetKeyspace); + this.sourceKeyspace = sourceKeyspace; + this.targetKeyspace = targetKeyspace; + this.sourceTableName = sourceTableName; + this.targetTableName = targetTableName; + } + + @Override + SchemaChange schemaChangeEvent(Keyspaces.KeyspacesDiff diff) + { + return new SchemaChange(SchemaChange.Change.CREATED, SchemaChange.Target.TABLE, targetKeyspace, targetTableName); + } + + @Override + public void authorize(ClientState client) + { + client.ensureTablePermission(sourceKeyspace, sourceTableName, Permission.SELECT); + client.ensureAllTablesPermission(targetKeyspace, Permission.CREATE); + } + + @Override + public AuditLogContext getAuditLogContext() + { + return new AuditLogContext(AuditLogEntryType.CREATE_TABLE_LIKE, targetKeyspace, targetTableName); + } + + public String toString() + { + return String.format("CREATE TABLE %s.%s LIKE %s.%s", targetKeyspace, targetTableName, sourceKeyspace, sourceTableName); + } + + @Override + public void validate(ClientState state) Review Comment: Hi , I replied [here](https://github.com/apache/cassandra/pull/3721/files#r1871469974), I think we may not need to do this , because the CQLs that are parsed are all create table like syntax, there will be no coexistence with create table syntax. For cql like `create table if not exist ta like tb` or some other cql that contains these three keywords : CREATE / TABLE / LIKE , only `create table a like b ` can be successfully paresd into copytablestatemnt, others will got a SyntaxException. I have a test for this in CreateLikeCqlParseTest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
