smiklosovic commented on code in PR #3374:
URL: https://github.com/apache/cassandra/pull/3374#discussion_r1876878115
##########
src/java/org/apache/cassandra/db/compaction/CompactionTask.java:
##########
@@ -126,8 +127,8 @@ protected void runMayThrow() throws Exception
if (DatabaseDescriptor.isSnapshotBeforeCompaction())
{
- Instant creationTime = now();
- cfs.snapshotWithoutMemtable(creationTime.toEpochMilli() +
"-compact-" + cfs.name, creationTime);
+ SnapshotOptions options = SnapshotOptions.systemSnapshot(cfs.name,
SnapshotType.COMPACT, cfs.getKeyspaceTableName()).skipFlush().build();
Review Comment:
not applicable, we indeed take snapshot on one table and before we operated
on `cfs` which was one table too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
