frankgh commented on code in PR #160:
URL: https://github.com/apache/cassandra-sidecar/pull/160#discussion_r1879182751
##########
server/src/main/java/org/apache/cassandra/sidecar/db/schema/SystemAuthSchema.java:
##########
@@ -80,14 +80,7 @@ public PreparedStatement getAllRolesAndIdentities()
private static class CqlLiterals
{
- static String selectRoleFromIdentity()
- {
- return "SELECT role FROM system_auth.identity_to_role WHERE
identity = ?";
- }
-
- static String getAllRolesAndIdentities()
- {
- return "SELECT * FROM system_auth.identity_to_role;";
- }
+ static final String SELECT_ROLE_FROM_IDENTITY = "SELECT role FROM
system_auth.identity_to_role WHERE identity = ?";
Review Comment:
no need for static methods, so I just changed to static constant definitions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
