belliottsmith commented on code in PR #150:
URL: https://github.com/apache/cassandra-accord/pull/150#discussion_r1884677679
##########
accord-core/src/main/java/accord/coordinate/ExecuteTxn.java:
##########
@@ -104,7 +106,7 @@ private Commit.Kind commitKind()
@Override
public void contact(Id to)
{
- if (SEND_MINIMUM_STABLE_MESSAGES) Commit.stableAndRead(to, node,
allTopologies, commitKind(), txnId, txn, route, readScope, executeAt,
stableDeps, this, SEND_MINIMUM_STABLE_MESSAGES);
+ if (SEND_MINIMUM_STABLE_MESSAGES && path != RECOVER)
Commit.stableAndRead(to, node, allTopologies, commitKind(), txnId, txn, route,
readScope, executeAt, stableDeps, this, false);
Review Comment:
I think it is irrelevant which parameter we provide here, as we should
always be a read contacting the primary topology. I can add a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
