smiklosovic commented on code in PR #3718:
URL: https://github.com/apache/cassandra/pull/3718#discussion_r1888019292
##########
test/unit/org/apache/cassandra/metrics/TableMetricsTest.java:
##########
@@ -296,6 +304,22 @@ public void testCounterStatement()
assertGreaterThan(cfs.metric.coordinatorWriteLatency.getMeanRate(), 0);
}
+ @Test
+ public void testCreateLikeTableMetric()
Review Comment:
@Maxwell-Guo I am not completely sure what is the added value of this test.
We can not just test absolutely everything again just because a table was
copied. Why is this test necessary? If we copy a table, it is as any other,
then it means that it will also behave like any other and we do need to test it
for the second time.
You just need to test that after you copy a table, that table is equal to
the source once, structurally, and is independent from the original one (e.g.
modification / alterations of fields and changing options does not change the
options on the original table).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
