smiklosovic commented on code in PR #3750:
URL: https://github.com/apache/cassandra/pull/3750#discussion_r1890082500
##########
src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java:
##########
@@ -64,15 +63,17 @@ public void execute(NodeProbe probe)
return;
}
- final long trueSnapshotsSize = probe.trueSnapshotsSize();
TableBuilder table = new TableBuilder();
// display column names only once
- final List<String> indexNames =
snapshotDetails.entrySet().iterator().next().getValue().getTabularType().getIndexNames();
+ List<String> indexNames =
snapshotDetails.entrySet().iterator().next().getValue().getTabularType().getIndexNames();
+ indexNames.subList(0, indexNames.size() - 1);
Review Comment:
the logic below deals this the fact that we do not want to display "Raw true
size" (or ... do we?) in nodetool status list.
I think it makes perfect sense to show it too, but since we are very
cautious about how the output looks like, we are not displaying that.
It might be exposed by additional argument as done in case of ephemeral
snapshots (`-e` flag), here we would introduced `-t` flag for "true size" or
similar: `nodetool listsnapshots -e -t` ... you got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
