sarankk commented on code in PR #165:
URL: https://github.com/apache/cassandra-sidecar/pull/165#discussion_r1893255979
##########
server/src/main/java/org/apache/cassandra/sidecar/routes/RingHandler.java:
##########
@@ -95,15 +107,15 @@ protected void processFailure(Throwable cause,
return;
}
- super.processFailure(cause, context, host, remoteAddress, keyspace);
+ super.processFailure(cause, context, host, remoteAddress, request);
}
/**
* {@inheritDoc}
*/
@Override
- protected Name extractParamsOrThrow(RoutingContext context)
+ protected Void extractParamsOrThrow(RoutingContext context)
{
- return keyspace(context, false);
+ return null;
Review Comment:
For Ring call across keyspaces, we do not take in keyspace. Hence using the
default implementation of taking in void request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
