netudima commented on code in PR #3761:
URL: https://github.com/apache/cassandra/pull/3761#discussion_r1901133811
##########
src/java/org/apache/cassandra/cql3/CQLStatement.java:
##########
@@ -32,9 +34,9 @@ public interface CQLStatement
/**
* Returns all bind variables for the statement
*/
- default List<ColumnSpecification> getBindVariables()
+ default ImmutableList<ColumnSpecification> getBindVariables()
{
- return Collections.emptyList();
Review Comment:
The problem is with ImmutableList.copyOf(columnSpecs) within
OptionsWithColumnSpecifications constructor, we have to copy columnSpecs for
every request because in one place plain List is used and in another -
ImmutableList
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
