joao-r-reis commented on code in PR #1952:
URL:
https://github.com/apache/cassandra-java-driver/pull/1952#discussion_r1923721373
##########
core/src/main/java/com/datastax/oss/driver/api/core/type/DataTypes.java:
##########
@@ -69,12 +66,21 @@ public static DataType custom(@NonNull String className) {
/* Vector support is currently implemented as a custom type but is also
parameterized */
if (className.startsWith(DefaultVectorType.VECTOR_CLASS_NAME)) {
- List<String> params =
- paramSplitter.splitToList(
- className.substring(
- DefaultVectorType.VECTOR_CLASS_NAME.length() + 1,
className.length() - 1));
- DataType subType = classNameParser.parse(params.get(0),
AttachmentPoint.NONE);
- int dimensions = Integer.parseInt(params.get(1));
+ String paramsString =
Review Comment:
Does it make sense to improve paramSplitter to work for these cases instead?
Maybe Bret's feedback here is needed as well @absurdfarce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
