ribaraka commented on code in PR #1861:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1861#discussion_r1928570991
##########
.github/workflows/main.yml:
##########
@@ -113,7 +113,7 @@ jobs:
go test -v -tags "${{ matrix.tags }} gocql_debug" -timeout=5m -race
${{ env.args }}
- name: 'Save ccm logs'
if: 'failure()'
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
name: ccm-cluster
path: /home/runner/.ccm/test
Review Comment:
There are breaking changes in version 4.
The
[actions/upload-artifact](https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes)
documentation states that artifacts are immutable, and you can no longer
upload to the same artifact name multiple times. It should be either upload to
multiple artifacts with different names or upload everything at once.
Otherwise, you will encounter an error.
Since this job uses a matrix, and judging by the documentation and current
implementation, it could lead to errors if multiple matrix jobs fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
