jmckenzie-dev commented on PR #3696: URL: https://github.com/apache/cassandra/pull/3696#issuecomment-2616758873
k, signposting intent here @ekaterinadimitrova2 and @michaelsembwever: 1. I'll get internal CI working w/this branch and JDK21, so then I can... 2. revert the experimental bytebuddy again and see how it behaves (think I erroneously attributed failures to it on subsequent run that weren't it) w/out having an external "please run CI for me" dep 3. I'll double-check to make sure I captured all the changed default GC params (that was work that Marcus did I wasn't involved in and it got absorbed into the diff I then upstreamed; I need to more deeply familiarize myself with that changeset to make sure I revert it), and finally 4. I'll work through any and all test failures, ensuring any erroneous test changes (haven't looked at the code yet; chaotic Monday) are addressed, with a bias toward reverting to baseline if possible and passing. I'm going to set this PR "on deck" for a week or two to address another priority, then will work through all this in a closed loop and surface if I get blocked on or need a 2nd pair of eyes on anything. That way we can break out of the long-async cycles we've been having on review / integration on this branch and hopefully push it across the line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
