dcapwell commented on code in PR #3835:
URL: https://github.com/apache/cassandra/pull/3835#discussion_r1932634898
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -554,7 +554,7 @@ public enum CassandraRelevantProperties
TCM_USE_NO_OP_REPLICATOR("cassandra.test.use_no_op_replicator", "false"),
TEST_BBFAILHELPER_ENABLED("test.bbfailhelper.enabled"),
- TEST_BLOB_SHARED_SEED("cassandra.test.blob.shared.seed"),
+ TEST_BLOB_SHARED_SEED("cassandra.test.blob.shared.seed", "42"),
Review Comment:
so, the tests use `qt()` and controls the seed for the test. The blob logic
has a giant blob that is shared by all tests, and uses a seed to populate the
bytes... this seed is decoupled from the test seed, and would use
`currentTimeMillis`; this caused the tests to be non-deterministic and not
repeatable when errors were found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
