tengu-alt commented on PR #1858: URL: https://github.com/apache/cassandra-gocql-driver/pull/1858#issuecomment-2621671096
> A possible approach is to move the logic from h.connectAddressLocked() to a function outside of the hostinfo type, use it to compute the connect address and then use the result to create the host info object afterwards. I don't clearly understand how we can use the logic from the `h.connectAddressLocked()` if it computes `connectAddress` according to the IP`s from the `host` which needs to be filled. As I see those IP`s are filled inside of the `hostInfoFromMap()` method which requires `*HostInfo`. I think it is better to create raw structure here as it is now an validate `connectAddress` inside of the `hostInfoFromMap()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
