worryg0d commented on code in PR #1793:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1793#discussion_r1937126677
##########
query_executor.go:
##########
@@ -41,6 +41,7 @@ type ExecutableQuery interface {
Keyspace() string
Table() string
IsIdempotent() bool
+ GetHostID() string
Review Comment:
It was the first approach I've proposed. We discussed this with
@joao-r-reis. If you have an opinion on this, let's discuss it
[here](https://github.com/apache/cassandra-gocql-driver/pull/1793#discussion_r1850752379).
TL;DR
We have two solutions how to avoid type casts and make the implementation
more obvious:
1. Extend `ExecutableQuery` interface, because it can't be implemented
outside gocql due to private methods like `execute`, so we cannot consider it a
breaking change.
2. Extract private methods from `ExecutableQuery` to an internal interface
which also should implement `ExecutableQuery` and use it internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
