sarankk commented on code in PR #179: URL: https://github.com/apache/cassandra-sidecar/pull/179#discussion_r1941987079
########## server/src/main/java/org/apache/cassandra/sidecar/acl/authorization/FeaturePermission.java: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.acl.authorization; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; + +import io.vertx.ext.auth.authorization.WildcardPermissionBasedAuthorization; +import io.vertx.ext.auth.authorization.impl.WildcardPermissionBasedAuthorizationImpl; + +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.CREATE_RESTORE_JOB; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.CREATE_SNAPSHOT; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.DELETE_RESTORE_JOB; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.DELETE_SNAPSHOT; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.DELETE_STAGED_SSTABLE; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.EDIT_RESTORE_JOB; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.IMPORT_STAGED_SSTABLE; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.READ_GOSSIP; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.READ_RESTORE_JOB; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.READ_RING_KEYSPACE_SCOPED; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.READ_SCHEMA; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.READ_SCHEMA_KEYSPACE_SCOPED; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.READ_SNAPSHOT; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.READ_TOPOLOGY; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.STREAM_SNAPSHOT; +import static org.apache.cassandra.sidecar.acl.authorization.BasicPermissions.UPLOAD_STAGED_SSTABLE; +import static org.apache.cassandra.sidecar.acl.authorization.CassandraPermissions.MODIFY; +import static org.apache.cassandra.sidecar.acl.authorization.CassandraPermissions.SELECT; +import static org.apache.cassandra.sidecar.acl.authorization.ResourceScopes.TABLE; + +/** + * Enumerates a list of feature level permissions that Sidecar recognizes and honors. + */ +public enum FeaturePermission +{ + BULK_READ_DIRECT("ANALYTICS:READ_DIRECT", + READ_RING_KEYSPACE_SCOPED, + READ_SCHEMA_KEYSPACE_SCOPED, + CREATE_SNAPSHOT, + READ_SNAPSHOT, + DELETE_SNAPSHOT, + STREAM_SNAPSHOT, + new StandardPermission(SELECT.name()).withScope(TABLE)), + + BULK_WRITE_DIRECT("ANALYTICS:WRITE_DIRECT", + READ_SCHEMA_KEYSPACE_SCOPED, + READ_GOSSIP, + READ_TOPOLOGY, + UPLOAD_STAGED_SSTABLE, + IMPORT_STAGED_SSTABLE, + DELETE_STAGED_SSTABLE, + new StandardPermission(MODIFY.name()).withScope(TABLE)), + + BULK_WRITE_S3_COMPAT("ANALYTICS:WRITE_S3_COMPAT", + READ_SCHEMA, + READ_TOPOLOGY, + CREATE_RESTORE_JOB, + READ_RESTORE_JOB, + EDIT_RESTORE_JOB, + DELETE_RESTORE_JOB), + + CDC("CDC", BasicPermissions.CDC); + + // TODO make forbidden feature permission configurable + private static final Set<String> FORBIDDEN_FEATURE_PERMISSION = Collections.singleton("*:*"); + + private static final List<FeaturePermission> FEATURE_PERMISSIONS + = Arrays.stream(values()).collect(Collectors.toList()); + + private final WildcardPermissionBasedAuthorization nameAuthorization; + private final CompositePermission permission; + + FeaturePermission(String name, Permission... permissions) + { + this.nameAuthorization = new WildcardPermissionBasedAuthorizationImpl(name); + this.permission + = new CompositePermission(name, Arrays.stream(permissions).collect(Collectors.toList())); + } + + public Permission permission() + { + return permission; + } + + /** + * Returns a {@link CompositePermission} if a feature level permission match is found for given permission name. + * {@link CompositePermission} consists of all basic permissions associated with given feature level permission. + * + * @param name permission name + * @return a {@link CompositePermission} containing the basic permissions that correspond to given feature level + * permission, or {@code null} if no match is found. + */ + public static Permission fromName(String name) + { + if (FORBIDDEN_FEATURE_PERMISSION.contains(name)) + { + return null; + } + List<Permission> combinedPermissions = new ArrayList<>(); + WildcardPermissionBasedAuthorization requestedAuthorization = new WildcardPermissionBasedAuthorizationImpl(name); + for (FeaturePermission featurePermission : FEATURE_PERMISSIONS) + { + if (requestedAuthorization.verify(featurePermission.nameAuthorization)) Review Comment: Yes to support feature level permission naming in format `domain:action` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
