yifan-c commented on code in PR #185:
URL: https://github.com/apache/cassandra-sidecar/pull/185#discussion_r1942002650
##########
server/src/test/integration/org/apache/cassandra/sidecar/routes/StreamStatsIntegrationTest.java:
##########
@@ -123,11 +123,9 @@ void assertStreamStatsResponseOK(HttpResponse<Buffer>
response, AtomicBoolean ha
if (streamProgress.totalFilesToReceive() > 0)
{
hasStats.set(true);
- if (streamProgress.totalFilesToReceive() ==
streamProgress.totalFilesReceived() &&
- streamProgress.totalFilesReceived() > 0)
Review Comment:
Talked offline. It is a timing issue. When client making the request, the
stream has just finished, cassandra responds with `totalFilesReceived == 0`,
which violates the second condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
