aweisberg commented on code in PR #3754:
URL: https://github.com/apache/cassandra/pull/3754#discussion_r1945686549
##########
src/java/org/apache/cassandra/db/lifecycle/View.java:
##########
@@ -353,4 +361,19 @@ public boolean apply(T t)
}
};
}
+
+ private static int getSSTablesHash(Iterable<SSTableReader> readers) {
+ int hashSum = 0;
Review Comment:
A 32-bit non-cryptographic hash isn't strong enough here. This could
realistically collide.
It would really be better to arrange it so that you can compare them
directly by say making sure the incoming iteration order is on something like
sstable id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
