ifesdjeen commented on code in PR #171:
URL: https://github.com/apache/cassandra-accord/pull/171#discussion_r1961794580
##########
accord-core/src/main/java/accord/primitives/Range.java:
##########
@@ -208,10 +207,10 @@ public int compareEndTo(RoutableKey key)
private Range(RoutingKey start, RoutingKey end)
{
- if (start.compareTo(end) >= 0)
- throw new IllegalArgumentException(start + " >= " + end);
- if (startInclusive() == endInclusive())
- throw illegalState("Range must have one side inclusive, and the
other exclusive. Range of different types should not be mixed.");
+ // TODO (expected): should we at least relax to permit an empty Range?
+ Invariants.requireArgument(start.compareTo(end) < 0, start + " >= " +
end);
Review Comment:
nit string concatenation to format? (pre-existing though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
