smiklosovic commented on code in PR #3908:
URL: https://github.com/apache/cassandra/pull/3908#discussion_r1967320667


##########
src/java/org/apache/cassandra/security/FileBasedSslContextFactory.java:
##########
@@ -308,12 +308,15 @@ private static String resolvePassword(String 
keystoreFilePath, String password,
                 return password;
 
             if (StringUtils.isEmpty(passwordFilePath))
-                return null;
+                return password;

Review Comment:
   @maulin-vasavada  I have changed my mind: 
https://issues.apache.org/jira/browse/CASSANDRA-13428?focusedCommentId=17929657&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17929657



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to