belliottsmith commented on code in PR #173:
URL: https://github.com/apache/cassandra-accord/pull/173#discussion_r1968447221
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -604,14 +606,15 @@ public static AsyncChain<Void>
applyWrites(SafeCommandStore safeStore, PreLoadCo
CommandStore unsafeStore = safeStore.commandStore();
Command.Executed executed = command.asExecuted();
Participants<?> executes = executed.participants().stillExecutes();
- if (!executes.isEmpty())
- return command.writes().apply(safeStore, executes,
command.partialTxn())
- .flatMap(unused -> unsafeStore.build(context, ss -> {
- postApply(ss, command);
- return null;
- }));
- else
+ if (executes.isEmpty())
return AsyncChains.success(null);
+
+ TxnId txnId = command.txnId();
+ return command.writes().apply(safeStore, executes,
command.partialTxn())
+ .flatMap(unused -> unsafeStore.build(context, ss -> {
+ postApply(ss, txnId, 0);
Review Comment:
We didn't previously update the timestamps here, this is used by journal
replay. I've added a check to only invoke the callback if > 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
