yifan-c commented on code in PR #198:
URL: https://github.com/apache/cassandra-sidecar/pull/198#discussion_r1988085248
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/ApiEndpointsV1.java:
##########
@@ -121,13 +121,16 @@ public final class ApiEndpointsV1
public static final String LIST_CDC_SEGMENTS_ROUTE = API_V1 + CDC_PATH +
"/segments";
public static final String STREAM_CDC_SEGMENTS_ROUTE =
LIST_CDC_SEGMENTS_ROUTE + "/" + SEGMENT_PATH_PARAM;
+ // Schema Reporting
+ private static final String REPORT_SCHEMA = "/report-schema";
+ public static final String REPORT_SCHEMA_ROUTE = API_V1 + REPORT_SCHEMA;
Review Comment:
In a RESTful design, the resource in the plural form is a more popular
convention. The API is to publishing/inserting a schema entity in the Datahub's
`entities` resource. The intent of publishing is expressed by the HTTP verb
(`PUT`. TBH, it should be `POST`, but I am fine with `PUT`), and the receiver
is the resource collection, i.e. `schemas`. `datahub` in the API is to clarify
the external service.
As mentioned in my previous comment, in DataHub's term, they are `entities`.
But in the consideration of the sidecar clients, it is clearer with calling
them `schemas`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
