maedhroz commented on code in PR #3955:
URL: https://github.com/apache/cassandra/pull/3955#discussion_r1989923960
##########
test/unit/org/apache/cassandra/exceptions/RequestFailureReasonTest.java:
##########
@@ -54,4 +57,48 @@ public void testEnumCodesAndNames()
assertEquals("Number of RequestFailureReason enum constants has
changed. Update the test.",
EXPECTED_VALUES.length, REASONS.length);
}
+
+ @Test
+ public void testFromCode()
+ {
+ // Test valid codes
+ assertEquals(RequestFailureReason.UNKNOWN,
RequestFailureReason.fromCode(0));
+ assertEquals(RequestFailureReason.READ_TOO_MANY_TOMBSTONES,
RequestFailureReason.fromCode(1));
+ assertEquals(RequestFailureReason.TIMEOUT,
RequestFailureReason.fromCode(2));
+ assertEquals(RequestFailureReason.INCOMPATIBLE_SCHEMA,
RequestFailureReason.fromCode(3));
+ assertEquals(RequestFailureReason.READ_SIZE,
RequestFailureReason.fromCode(4));
+ assertEquals(RequestFailureReason.NODE_DOWN,
RequestFailureReason.fromCode(5));
+ assertEquals(RequestFailureReason.INDEX_NOT_AVAILABLE,
RequestFailureReason.fromCode(6));
+ assertEquals(RequestFailureReason.READ_TOO_MANY_INDEXES,
RequestFailureReason.fromCode(7));
+ assertEquals(RequestFailureReason.NOT_CMS,
RequestFailureReason.fromCode(8));
+ assertEquals(RequestFailureReason.INVALID_ROUTING,
RequestFailureReason.fromCode(9));
+ assertEquals(RequestFailureReason.COORDINATOR_BEHIND,
RequestFailureReason.fromCode(10));
+ assertEquals(RequestFailureReason.INDEX_BUILD_IN_PROGRESS,
RequestFailureReason.fromCode(503));
Review Comment:
nit: Can we just use `EXPECTED_VALUES` to test these in a loop? At least
that way we only have to modify `EXPECTED_VALUES` when we add a new code...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
