dcapwell commented on code in PR #3954:
URL: https://github.com/apache/cassandra/pull/3954#discussion_r1990401379
##########
src/java/org/apache/cassandra/service/accord/api/TokenKey.java:
##########
@@ -193,6 +180,20 @@ public RoutingKey toUnseekable()
return this;
}
+ public boolean isMin()
+ {
+ //TODO (review): some code paths don't care if before/after are used,
but some are not fully correct (range.isFullRange)
+// return sentinel == MIN_TABLE_SENTINEL;
+ return (sentinel & PREFIX_MASK) == (MIN_TABLE_SENTINEL & PREFIX_MASK);
Review Comment:
`min().before().isMin() == false` without this patch, but it looks like most
code paths don't want this behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
