ifesdjeen commented on code in PR #3976:
URL: https://github.com/apache/cassandra/pull/3976#discussion_r1992194636
##########
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java:
##########
@@ -1149,7 +1149,7 @@ public void close()
.collect(Collectors.toList());
try
{
- FBUtilities.waitOnFutures(futures, 1L, TimeUnit.MINUTES);
+ FBUtilities.waitOnFutures(futures, instances.size(),
TimeUnit.MINUTES);
Review Comment:
looks like on CI, we sometimes do not manage to shutdown within 1 minute
after tests that have a lot of background work scheduled. We can probably
become better with interrupts, but meanwhile.
##########
src/java/org/apache/cassandra/service/accord/CommandsForRanges.java:
##########
@@ -102,22 +104,34 @@ private Loader newLoader(Unseekables<?>
searchKeysOrRanges, RedundantBefore redu
return new Loader(this, searchKeysOrRanges, redundantBefore,
testKind, minTxnId, maxTxnId, findAsDep);
}
+ private void updateTransitive(UnaryOperator<NavigableMap<TxnId,
Ranges>> update)
Review Comment:
This one fixes `transitive` map concurrent access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
