jahstreet commented on code in PR #2013:
URL:
https://github.com/apache/cassandra-java-driver/pull/2013#discussion_r2000572246
##########
core/src/main/java/com/datastax/oss/driver/internal/core/ContactPoints.java:
##########
@@ -41,7 +38,22 @@ public static Set<EndPoint> merge(
Set<EndPoint> result = Sets.newHashSet(programmaticContactPoints);
for (String spec : configContactPoints) {
- for (InetSocketAddress address : extract(spec, resolve)) {
+
+ Set<InetSocketAddress> addresses = Collections.emptySet();
+ try {
+ addresses = AddressUtils.extract(spec, resolve);
+ } catch (RuntimeException e) {
+ LOG.warn("Ignoring invalid contact point {} ({})", spec,
e.getMessage(), e);
+ }
+
+ if (addresses.size() > 1) {
+ LOG.info(
+ "Contact point {} resolves to multiple addresses, will use them
all ({})",
+ spec,
+ addresses);
+ }
Review Comment:
Same as above, it was there so I kept it as is.
As for me, this log is a good additional info when debugging failed to
connect issues. Like, one could be surprised to see the client failed to
connect logs where contact points do not match the configured ones.
What is your opinion on the need of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
