dcapwell commented on code in PR #3995:
URL: https://github.com/apache/cassandra/pull/3995#discussion_r2004337363
##########
test/distributed/org/apache/cassandra/distributed/test/cql3/SingleNodeTableWalkTest.java:
##########
@@ -363,7 +386,8 @@ protected TableMetadata defineTable(RandomSource rs, String
ks)
.withCompression())
.withKeyspaceName(ks).withTableName("tbl")
.withSimpleColumnNames()
- .withDefaultTypeGen(supportedTypes())
+ .withDefaultTypeGen(supportedTypes(rs))
+ .withPrimaryColumnTypeGen(supportedPrimaryColumnTypes(rs))
Review Comment:
when primary keys can be collections there can be issues with having too
many bytes and having our mutations be rejected. Keeping it primitive also
improves readability for debug output...
Would be good to have a test that overrides this though, just to improve
coverage...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
