frankgh commented on code in PR #211:
URL: https://github.com/apache/cassandra-sidecar/pull/211#discussion_r2004399014
##########
conf/sidecar.yaml:
##########
@@ -121,20 +121,37 @@ sidecar:
replication_strategy: SimpleStrategy
replication_factor: 1
# The TTL in seconds used to insert entries into the sidecar_lease schema
- lease_schema_ttl: 2m
+ lease_schema_ttl: 5m
coordination:
# Captures configuration parameters for the task that performs the cluster
lease claim process
cluster_lease_claim:
+ # The name of the strategy used to determine the electorate membership
+ # Out of the box Sidecar provides the
MostReplicatedKeyspaceTokenZeroElectorateMembership, and
+ # SidecarInternalTokenZeroElectorateMembership implementations.
+ # - MostReplicatedKeyspaceTokenZeroElectorateMembership the current
Sidecar will be determined to be part
+ # of the
electorate iff one of the Cassandra instances it
+ # manages owns
token 0 for the user keyspace that has the
+ # highest
replication factor. If multiple keyspaces have
+ # the highest
replication factor, the keyspace to be used
+ # is decided by
the keyspace with the name that sorts
+ # first in the
lexicographic sort order. If no user
+ # keyspaces are
created, the internal sidecar keyspace will
+ # be used.
+ # - SidecarInternalTokenZeroElectorateMembership the current
Sidecar will be determined to be part of the
+ # electorate iff
one of the Cassandra instances it manages
+ # owns token
{@code 0} for the {@code sidecar_internal}
+ # keyspace.
+ electorate_membership_strategy:
MostReplicatedKeyspaceTokenZeroElectorateMembership
# Whether the process is enabled
enabled: true
# The initial delay for the first execution of the cluster lease claim
process task after being
# scheduled or rescheduled.
# The minimum value for the initial delay is 0ms.
- initial_delay: 1s
Review Comment:
yeah, I think that's fine. If you have a single sidecar instance there will
be no contention. i.e using the default configuration values for the
sidecar_internal keyspace and `SidecarInternalTokenZeroElectorateMembership`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
