joao-r-reis commented on code in PR #1855:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1855#discussion_r2026783614
##########
session.go:
##########
@@ -158,9 +159,11 @@ func NewSession(cfg ClusterConfig) (*Session, error) {
pageSize: cfg.PageSize,
stmtsLRU: &preparedLRU{lru:
lru.New(cfg.MaxPreparedStmts)},
connectObserver: cfg.ConnectObserver,
- ctx: ctx,
- cancel: cancel,
- logger: cfg.logger(),
+ // TODO: switch to from the config
+ types: GlobalTypes,
Review Comment:
also we could add some logic here so that the user can't modify the
registrations after a session has been created and therefore not requiring
locking. Maybe copying the registrations to a new internal struct that only
supports reading them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
