tengu-alt opened a new pull request, #1875:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1875

   I've researched possible endless query execution when `HostSelectionPolicy` 
returns the same downed host 
([CASSGO-50](https://issues.apache.org/jira/browse/CASSGO-50)) and propose 
three approaches to prevent it.
   
   - Wrap `hostIter` to prevent it from returning downed host before executing 
the query. 
    e.g.
   ```
     hostIter = func() SelectedHost {
       checkIter := hostIter()
       if !checkIter.Info().IsUp() {
         return nil
       }
       return checkIter
     }
   ```
   But that approach can cause breaking changes.
   
   - Properly documented `type NextHost func()`:
   Add a comment for `NextHost` type describing that `NextHost` should return 
not downedhost or return nil
   
   - Add the threshold limit based on the number of hosts inside `(q 
*queryExecutor) do` which will prevent the endless execution without the 
breaking changes
   
   Implementations of the threshold and documentation are presented in this PR.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to