yifan-c commented on code in PR #213:
URL: https://github.com/apache/cassandra-sidecar/pull/213#discussion_r2035948342
##########
server/src/test/java/org/apache/cassandra/sidecar/cdc/CdcConfigImplTest.java:
##########
@@ -137,6 +146,8 @@ void testConfigsWhenConfigsAreNotEmpty()
assertThat(cdcConfig.env()).isEqualTo("if");
assertThat(cdcConfig.kafkaTopic()).isEqualTo("topic1");
assertThat(cdcConfig.logOnly()).isFalse();
+ assertThat(cdcConfig.watermarkWindow()).isEqualTo(new
MinuteBoundConfiguration(2, TimeUnit.MINUTES));
Review Comment:
and this. should it be `SecondBoundConfiguration`?
##########
server/src/test/java/org/apache/cassandra/sidecar/cdc/CdcConfigImplTest.java:
##########
@@ -118,6 +120,8 @@ void testReturnDefaultValuesWhenConfigsAreEmpty()
assertThat(cdcConfig.env()).isEqualTo("");
assertThat(cdcConfig.kafkaTopic()).isNull();
assertThat(cdcConfig.logOnly()).isFalse();
+ assertThat(cdcConfig.watermarkWindow()).isEqualTo(new
MinuteBoundConfiguration(72, TimeUnit.HOURS));
Review Comment:
should this be `SecondBoundConfiguration`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
