jaibheem commented on code in PR #4075:
URL: https://github.com/apache/cassandra/pull/4075#discussion_r2037933699
##########
src/java/org/apache/cassandra/dht/RangeStreamer.java:
##########
@@ -331,8 +332,12 @@ public void addRanges(String keyspaceName,
ReplicaCollection<?> replicas)
Multimap<InetAddressAndPort, FetchReplica> workMap;
//Only use the optimized strategy if we don't care about strict
sources, have a replication factor > 1, and no
- //transient replicas.
- if (useStrictSource || strat == null ||
strat.getReplicationFactor().allReplicas == 1 ||
strat.getReplicationFactor().hasTransientReplicas())
+ //transient replicas or it is intentionally skipped.
+ if
(CassandraRelevantProperties.SKIP_OPTIMAL_STREAMING_CANDIDATES_CALCULATION.getBoolean()
||
+ useStrictSource ||
+ strat == null ||
+ strat.getReplicationFactor().allReplicas == 1 ||
+ strat.getReplicationFactor().hasTransientReplicas())
{
workMap = convertPreferredEndpointsToWorkMap(fetchMap);
Review Comment:
can we add a Info log per keyspaces so it's evident for the users who opted
for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
