dcapwell commented on code in PR #4079:
URL: https://github.com/apache/cassandra/pull/4079#discussion_r2038427138
##########
src/java/org/apache/cassandra/db/marshal/MultiElementType.java:
##########
@@ -57,16 +57,6 @@ public ByteBuffer pack(List<ByteBuffer> elements)
return pack(elements, ByteBufferAccessor.instance);
}
- public final ByteBuffer packBuffer(List<ByteBuffer> elements)
Review Comment:
we added these methods and then they got added on trunk, so duplicate logic.
These functions are also dead code
##########
src/java/org/apache/cassandra/db/marshal/TupleType.java:
##########
@@ -383,7 +383,7 @@ public <V> V pack(List<V> elements, ValueAccessor<V>
accessor)
public ByteBuffer pack(ByteBuffer... components)
{
- return pack(Arrays.asList(components), ByteBufferAccessor.instance);
+ return pack(Arrays.asList(components));
Review Comment:
when i did the last rebase this change got added else the history got too
hard to work with; so rolling back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
