k-rus commented on code in PR #4038:
URL: https://github.com/apache/cassandra/pull/4038#discussion_r2041084356
##########
src/java/org/apache/cassandra/schema/TableMetadata.java:
##########
@@ -688,7 +693,40 @@ public ClusteringComparator
partitionKeyAsClusteringComparator()
public String indexTableName(IndexMetadata info)
{
// TODO simplify this when info.index_name is guaranteed to be set
- return name + Directories.SECONDARY_INDEX_NAME_SEPARATOR + info.name;
+ return name + SECONDARY_INDEX_NAME_SEPARATOR + info.name;
+ }
+
+ /**
+ * Returns the table part of the index table name or the entire table name
+ * if not an index table.
+ * @return table name part
+ */
+ public String getTableName()
+ {
+ int idx = name.indexOf(SECONDARY_INDEX_NAME_SEPARATOR);
+ return idx >= 0 ? name.substring(0, idx) : name;
+ }
+
+ /**
+ * Generates directory name for the table by using table part of
+ * the (index) table name and table id.
+ * @return directory name
+ */
+ public String getTableDirectoryName()
+ {
+ return getTableName() + '-' + id.toHexString();
+ }
+
+ /**
+ * Gets the index name from the name of the index table including dot
prefix.
Review Comment:
Good point about the confusing description. I also agree that the dot is
specific to the caller, however, removing the dot will bloat the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
