dcapwell commented on code in PR #4105:
URL: https://github.com/apache/cassandra/pull/4105#discussion_r2051183219
##########
test/unit/org/apache/cassandra/utils/CassandraGenerators.java:
##########
@@ -563,11 +565,39 @@ public static class CompactionParamsBuilder
Map<String, String> options = new HashMap<>();
if (nextBoolean(rnd))
options.putAll(sizeTieredOptions.generate(rnd));
+ int maxSSTableSizeInMB =
LeveledCompactionStrategy.DEFAULT_MAX_SSTABLE_SIZE_MIB;
if (nextBoolean(rnd))
+ {
// size in mb
- options.put(LeveledCompactionStrategy.SSTABLE_SIZE_OPTION,
SourceDSL.integers().between(1, 2_000).generate(rnd).toString());
+ maxSSTableSizeInMB = SourceDSL.integers().between(1,
2_000).generate(rnd);
+ options.put(LeveledCompactionStrategy.SSTABLE_SIZE_OPTION,
Integer.toString(maxSSTableSizeInMB));
+ }
if (nextBoolean(rnd))
-
options.put(LeveledCompactionStrategy.LEVEL_FANOUT_SIZE_OPTION,
SourceDSL.integers().between(1, 100).generate(rnd).toString());
+ {
+ // there is a relationship between sstable size and fanout, so
respect it
Review Comment:
one seed randomly hit this case, so fix it so we don't happen again...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
