dcapwell commented on code in PR #4134:
URL: https://github.com/apache/cassandra/pull/4134#discussion_r2072005406
##########
test/unit/org/apache/cassandra/cql3/ReservedKeywordsTest.java:
##########
@@ -30,14 +34,51 @@ public void testReservedWordsForColumns()
{
for (String reservedWord : ReservedKeywords.reservedKeywords)
{
- try
- {
- QueryProcessor.parseStatement(String.format("ALTER TABLE ks.t
ADD %s TEXT", reservedWord));
+ if (isAllowed(reservedWord))
Assert.fail(String.format("Reserved keyword %s should not have
parsed", reservedWord));
- }
- catch (SyntaxException ignore)
- {
- }
+ }
+ }
+
+ @Test
+ public void parserAndTextFileMatch()
Review Comment:
this test isn't 100% replacing the other one, as there is always the chance
the Lexer is missing something in the text file, so the other one is still
useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
