dcapwell commented on code in PR #190:
URL: https://github.com/apache/cassandra-accord/pull/190#discussion_r2082407560
##########
accord-core/src/main/java/accord/local/DurableBefore.java:
##########
@@ -18,26 +18,21 @@
package accord.local;
-import java.util.function.BiFunction;
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-
import accord.api.RoutingKey;
+import accord.primitives.*;
Review Comment:
`*` imports, we agreed about avoiding these
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -33,6 +33,7 @@
import javax.annotation.Nullable;
+import accord.primitives.*;
Review Comment:
can you revert the star import?
##########
accord-core/src/main/java/accord/local/DurableBefore.java:
##########
@@ -155,6 +150,27 @@ private DurableBefore()
}
}
+ public boolean fullyContainedIn(DurableBefore other)
+ {
+ if (values == NO_OBJECTS)
+ return true;
+
+ for (int i = 0 ; i < values.length; i++)
+ {
+ if (values[i] != null &&
+
!other.foldlWithDefault(Ranges.of(starts[i].rangeFactory().newRange(starts[i],
starts[i + 1])),
+ (v, a) -> {
+ System.out.println("v = " + v);
Review Comment:
remove `println`, its fine to use a logger but not stdout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
