dcapwell commented on code in PR #3696:
URL: https://github.com/apache/cassandra/pull/3696#discussion_r2082430854
##########
build.xml:
##########
@@ -307,6 +307,72 @@
<equals arg1="${ant.java.version}" arg2="17"/>
</condition>
+ <resources id="_jvm21_arg_items">
+ <string>-Djdk.attach.allowAttachSelf=true</string>
+
+ <string>-XX:+UseZGC</string>
Review Comment:
Can we revert this and switch to g1? We talked about this on slack, so
putting here.
In testing this there were tests where the only GC that caused failure was
ZGC. This could be because CI uses a 1g heap, but wasn't explored further.
G1GC made CI stable, and actually avoids some other changes this patch makes.
```
<!-- Temporary workaround for jamm having incorrect default CompressedOops
for JDK21 -->
<string>-XX:-UseCompressedOops</string>
```
This change is i think because ZGC doesn't support and you are trying to
trick jamm, but even then I found memory issues. If we leave it enabled and
switch to G1GC we don't have to play as much wack-a-mole
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
