k-rus commented on code in PR #4038:
URL: https://github.com/apache/cassandra/pull/4038#discussion_r2083106088
##########
src/java/org/apache/cassandra/schema/TableMetadata.java:
##########
@@ -602,11 +606,16 @@ public boolean dependsOn(Function function)
public void validate()
{
- if (!isNameValid(keyspace))
- except("Keyspace name must not be empty, more than %s characters
long, or contain non-alphanumeric-underscore characters (got \"%s\")",
SchemaConstants.NAME_LENGTH, keyspace);
+ if (!isValidKeyspaceName(keyspace))
+ except("Keyspace name must not be empty, more than %s characters
long, or contain non-alphanumeric-underscore characters (got \"%s\")",
NAME_LENGTH, keyspace);
- if (!isNameValid(name))
- except("Table name must not be empty, more than %s characters
long, or contain non-alphanumeric-underscore characters (got \"%s\")",
SchemaConstants.NAME_LENGTH, name);
+ if (!isValidName(name))
+ except("Table name must not be empty or not contain
non-alphanumeric-underscore characters (got \"%s\")", name);
+
+ if (name.length() > TABLE_NAME_LENGTH)
Review Comment:
These two checks and the assert are replaced with a single method call to
`validateTableName`, which also encapsulates throwing an exception on invalid
table name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
