netudima commented on code in PR #2497:
URL: https://github.com/apache/cassandra/pull/2497#discussion_r2106310842
##########
src/java/org/apache/cassandra/tools/nodetool/GetTimeout.java:
##########
@@ -17,28 +17,33 @@
*/
package org.apache.cassandra.tools.nodetool;
-import io.airlift.airline.Arguments;
-import io.airlift.airline.Command;
-
+import org.apache.cassandra.tools.nodetool.layout.CassandraUsage;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Parameters;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
import org.apache.cassandra.tools.NodeProbe;
-import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
import static com.google.common.base.Preconditions.checkArgument;
@Command(name = "gettimeout", description = "Print the timeout of the given
type in ms")
-public class GetTimeout extends NodeToolCmd
+public class GetTimeout extends AbstractCommand
{
public static final String TIMEOUT_TYPES = "read, range, write,
counterwrite, cascontention, truncate, internodeconnect, internodeuser,
internodestreaminguser, misc (general rpc_timeout_in_ms)";
- @Arguments(usage = "<timeout_type>", description = "The timeout type, one
of (" + TIMEOUT_TYPES + ")")
+ @CassandraUsage(usage = "<timeout_type>", description = "The timeout type,
one of (" + TIMEOUT_TYPES + ")")
private List<String> args = new ArrayList<>();
+ @Parameters (index = "0", description = "The timeout type, one of (" +
TIMEOUT_TYPES + ')')
Review Comment:
should the parameter be mandatory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
