samueldlightfoot commented on code in PR #4178:
URL: https://github.com/apache/cassandra/pull/4178#discussion_r2108710076
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -1245,6 +1246,12 @@ public enum DiskAccessMode
direct
}
+ public enum ScanDiskAccessMode
+ {
+ disk_default,
Review Comment:
This enum was intended to differentiate scans using the default disk access
mode (conf.disk_access_mode via the existing dFile handle) from scans requiring
a new, direct file handle.
It may be better to use the existing DiskAccessMode enum and determine if a
new handle is needed by comparing the required mode against the default on
start-up. I am keen to hear thoughts.
Update: I see ioOptions (containing disk_access_mode) are available on the
SSTableReader. This should be fairly straight-forward to integrate to allow us
to determine whether to use the existing dFile or create another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
