smiklosovic commented on code in PR #4166:
URL: https://github.com/apache/cassandra/pull/4166#discussion_r2116306908


##########
bin/cassandra:
##########
@@ -188,6 +188,10 @@ launch_service()
         cassandra_parms="$cassandra_parms -Dcassandra-pidfile=$pidpath"
     fi
 
+    if [ "x$call_clean_heap_dump_files" != "x" ]; then
+        clean_heap_dump_files || true

Review Comment:
   @gowa by the way ... as things currently are, is not it true that 
`clean_heap_dump_files` will be sourced when `call_clean_heap_dump_files` is 
set to something? The only place you set it (to 1), is cassandra-env.sh. But in 
that  file, there is `clean_heap_dump_files` as well so ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to