aweisberg commented on code in PR #4111:
URL: https://github.com/apache/cassandra/pull/4111#discussion_r2122015997
##########
src/java/org/apache/cassandra/exceptions/RequestTimeoutException.java:
##########
@@ -40,4 +40,13 @@ protected RequestTimeoutException(ExceptionCode code,
ConsistencyLevel consisten
this.received = received;
this.blockFor = blockFor;
}
+
+ // TODO (review): Was there an intentional choice here that
RequestTimeoutException doesn't wrap its causes for brevity?
Review Comment:
It still won't get sent back the client since the message is calculated
separately. I think it should be fine to add it here.
##########
src/java/org/apache/cassandra/exceptions/RequestTimeoutException.java:
##########
@@ -40,4 +40,13 @@ protected RequestTimeoutException(ExceptionCode code,
ConsistencyLevel consisten
this.received = received;
this.blockFor = blockFor;
}
+
+ // TODO (review): Was there an intentional choice here that
RequestTimeoutException doesn't wrap its causes for brevity?
Review Comment:
It still won't get sent back the client since the message is generated
separately. I think it should be fine to add it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
