michaeljmarshall opened a new pull request, #4196: URL: https://github.com/apache/cassandra/pull/4196
[CASSANDRA-20709](https://issues.apache.org/jira/projects/CASSANDRA/issues/CASSANDRA-20709) SAI predicate search currently has a bug that could result in missing rows due to a concurrent flush during a query. The new test created in this PR shows the point of failure. The problem is that we get the sstable index references before getting the memtable index references. Note that we do it in the correct order in the `ANN OF` query path, but not in the `WHERE` query path. I propose that we update the QueryView object to hold references to the appropriate memtable indexes. I removed the problematic search methods from `MemtableIndexManager` because they leave open the possibility for future misuse, in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
